Skip to content

Adding integration test for logstash Metricbeat module, xpack code path#15800

Merged
ycombinator merged 5 commits intoelastic:masterfrom
ycombinator:mb-ls-xp-int-test
Jan 30, 2020
Merged

Adding integration test for logstash Metricbeat module, xpack code path#15800
ycombinator merged 5 commits intoelastic:masterfrom
ycombinator:mb-ls-xp-int-test

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator commented Jan 24, 2020 •
edited
Loading

This PR:

  • adds an integration test for the Metricbeat logstash module when xpack.enabled: true is set in the module configuration,
  • adds two new functions to the integration testing framework, NewReportingMetricSetV2Errors and NewMetricSets, in order to make the above test possible, and
  • does some minor cleanup in the Metricbeat logstash integration test code.

@ycombinator ycombinator requested a review from a team as a code owner January 24, 2020 01:25
houndci-bot
houndci-bot reviewed Jan 24, 2020
View reviewed changes
@ycombinator ycombinator requested review from a team and removed request for a team January 24, 2020 01:55
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 24, 2020

Pinging @elastic/stack-monitoring (Stack monitoring)

@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Jan 27, 2020

Blocked on #15819.

@ycombinator ycombinator mentioned this pull request Jan 30, 2020
Merged
3 tasks
@ycombinator ycombinator changed the title Adding integration test for Metricbeat logstash module, xpack data path Adding integration test for logstash Metricbeat module, xpack code path Jan 30, 2020
@ycombinator ycombinator mentioned this pull request Jan 30, 2020
Merged
3 tasks
@ycombinator
Copy link
Copy Markdown
Contributor Author

ycombinator commented Jan 30, 2020

Travis CI is green and Jenkins CI failures are unrelated. Merging.

@ycombinator ycombinator merged commit 0507118 into elastic:master Jan 30, 2020
@ycombinator ycombinator deleted the mb-ls-xp-int-test branch January 30, 2020 20:32
@ycombinator ycombinator mentioned this pull request Jan 30, 2020
Merged
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Jan 30, 2020
@ycombinator ycombinator mentioned this pull request Jan 30, 2020
Merged
3 tasks
ycombinator added a commit that referenced this pull request Feb 6, 2020
@ycombinator
Adding integration test for logstash Metricbeat module, xpack code pa…
63f3b08 
…th (#15800) (#15968)

* Adding integration test for logstash module, xpack data path

* Adding godoc

* Refactoring

* More refactoring

* Fixing reference
@andresrc andresrc added the Team:Integrations Label for the Integrations team label Mar 6, 2020
@ycombinator ycombinator mentioned this pull request Apr 8, 2020
Merged
ycombinator added a commit that referenced this pull request Apr 8, 2020
@ycombinator
Adding integration test for logstash Metricbeat module, xpack code pa…
e400ba0 
…th (#15800) (#17598)

* Adding integration test for logstash module, xpack data path

* Adding godoc

* Refactoring

* More refactoring

* Fixing reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@mtojek mtojek mtojek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Stack Monitoring Metricbeat Metricbeat module review Team:Integrations Label for the Integrations team :Testing v7.7.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ycombinator @elasticmachine @houndci-bot @mtojek @andresrc